Re: [PATCH net-next] virtio_net: bulk free tx skbs

From: David Miller
Date: Wed Jan 16 2019 - 18:32:06 EST


From: "Michael S. Tsirkin" <mst@xxxxxxxxxx>
Date: Mon, 14 Jan 2019 20:34:26 -0500

> Use napi_consume_skb() to get bulk free. Note that napi_consume_skb is
> safe to call in a non-napi context as long as the napi_budget flag is
> correct.
>
> Signed-off-by: Michael S. Tsirkin <mst@xxxxxxxxxx>
> ---
>
> My perf testing setup is down but it works fine on my devel box and
> should be fairly uncontroversial.

It would be uncontroversial if it compiled.

drivers/net/virtio_net.c: In function ʽfree_old_xmit_skbsʼ:
drivers/net/virtio_net.c:1346:25: error: ʽuse_napiʼ undeclared (first use in this function); did you mean ʽused_mathʼ?
napi_consume_skb(skb, use_napi);
^~~~~~~~
used_math
drivers/net/virtio_net.c:1346:25: note: each undeclared identifier is reported only once for each function it appears in