Re: [PATCH v2 2/2] leds: lp50xx: Add the LP50XX family of the RGB LED driver
From: Pavel Machek
Date: Wed Jan 16 2019 - 17:04:07 EST
Hi!
..snip. Let me read it and reply when I have a time.
> > You know what? First, submit driver with similar functionality to
> > existing RGB drivers, using same interface existing drivers are
> > using. When that is accepted, we can talk about extending
> > kernel<->user interfaces.
> >
>
> I could do that but then there is no way for users to have any other color but "white" with this driver.
> That defeats the purpose of the device itself.
No, that is not what I meant.
We do have RGB drivers in tree, they just present three separate LEDs
-- red, green and blue. I ask you to do the same for initial
submission.
You'll still be able to set brightness independently on the
red/green/blue LEDs...
> I am not sure if you are aware of this or care but I found this recent blog on this effort:
> https://www.phoronix.com/scan.php?page=news_item&px=Linux-RGB-LED-Interface
> See some of the comments.
I went through the comments quickly, but see nothing really
interesting.
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Attachment:
signature.asc
Description: Digital signature