Re: [PATCH v3] xen: Fix x86 sched_clock() interface for xen

[Juergen Gross]

On 16/01/2019 16:07, Boris Ostrovsky wrote:
> On 1/16/19 9:33 AM, Juergen Gross wrote:
>> On 16/01/2019 14:17, Boris Ostrovsky wrote:
>>> On Wed, Jan 16, 2019 at 08:50:13AM +0100, Juergen Gross wrote:
>>>
>>>> @@ -1650,13 +1650,14 @@ void xen_callback_vector(void)
>>>>                         xen_have_vector_callback = 0;
>>>>                         return;
>>>>                 }
>>>> -               pr_info("Xen HVM callback vector for event delivery is
>>>> enabled\n");
>>>> +               if (!silent)
>>>> +                       pr_info("Xen HVM callback vector for event
>>>> delivery is enabled\n");
>>> How about replacing pr_info() with pr_info_once()?
>> What a nice and simple idea!
>>
>> Extra patch or V4?
>>
> 
> 
> I can add this while committing, I don't think it's worth a whole new patch.
> 
> One outstanding question I have is whether anything needs to be added to
> the commit message (Thomas had some questions)

He didn't react to my explanation. I'm interpreting that as him being
fine with my explanation, which I believe is not suitable to be added
to the commit message.


Juergen