Re: [PATCH v2 1/5] spmi: pmic-arb: hardcode IRQ counts

From: Stephen Boyd
Date: Mon Jan 07 2019 - 16:26:10 EST


Quoting Brian Masney (2019-01-06 18:11:41)
> @@ -1062,19 +1076,6 @@ static int pmic_gpio_remove(struct platform_device *pdev)
> return 0;
> }
>
> -static const struct of_device_id pmic_gpio_of_match[] = {
> - { .compatible = "qcom,pm8916-gpio" }, /* 4 GPIO's */
> - { .compatible = "qcom,pm8941-gpio" }, /* 36 GPIO's */
> - { .compatible = "qcom,pm8994-gpio" }, /* 22 GPIO's */
> - { .compatible = "qcom,pmi8994-gpio" }, /* 10 GPIO's */
> - { .compatible = "qcom,pma8084-gpio" }, /* 22 GPIO's */
> - { .compatible = "qcom,pms405-gpio" }, /* 12 GPIO's, holes on 1 9 10 */
> - { .compatible = "qcom,spmi-gpio" }, /* Generic */
> - { },
> -};
> -
> -MODULE_DEVICE_TABLE(of, pmic_gpio_of_match);
> -

Please don't move the array. It isn't necessary if you use
device_get_match_data() instead of of_match_device().