5.0-rc1 Open circuit voltage tables -- 3afb50d7125bc

From: Pavel Machek
Date: Mon Jan 07 2019 - 14:06:00 EST


Hi!

Can we do something with that code?

First -- tables should not be necceessary. Formula for li-ion open
circuit voltage is well-known, and does not really depend on the
device -- only on the chemistry of battery.

state of charge = f( voltage, current, internal resistance )

(And yes, internal resistance depends on temperature and health of the
battery).

Second, even if we need tables, why is it doing multiple allocations?

info->ocv_temp[index] = -EINVAL;

That's just wrong. Ocv_temp is temperature in celsius. Temperatures go
below zero.

Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Attachment: signature.asc
Description: Digital signature