Re: [PATCH v2 5/7] Input: dt-bindings: tm2-touchkey: Document new keycodes property

From: PaweÅ Chmiel
Date: Mon Jan 07 2019 - 13:53:27 EST


Dnia czwartek, 3 stycznia 2019 19:27:39 CET Rob Herring pisze:
> On Fri, Dec 28, 2018 at 4:52 PM Dmitry Torokhov
> <dmitry.torokhov@xxxxxxxxx> wrote:
> >
> > On Fri, Dec 28, 2018 at 2:47 PM Rob Herring <robh@xxxxxxxxxx> wrote:
> > >
> > > On Fri, 28 Dec 2018 16:46:07 +0100, =?UTF-8?q?Pawe=C5=82=20Chmiel?= wrote:
> > > > From: Jonathan Bakker <xc-racer2@xxxxxxx>
> > > >
> > > > Document new optional property for setting custom keycodes.
> > > >
> > > > Signed-off-by: Jonathan Bakker <xc-racer2@xxxxxxx>
> > > > Signed-off-by: PaweÅ Chmiel <pawel.mikolaj.chmiel@xxxxxxxxx>
> > > > ---
> > > > Changes from v1:
> > > > - Because key codes could be bigger than 255, use ints for keycodes
> > > > ---
> > > > .../devicetree/bindings/input/cypress,tm2-touchkey.txt | 4 ++++
> > > > 1 file changed, 4 insertions(+)
> > > >
> > >
> > > Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
> >
> > Shouldn't this be "linux,keycodes" though?
>
> Sigh, yes.
>
> Rob
I'll send v3 version with this property name fixed (both in documentation and in driver).

Thanks