Re: [PATCH v3] mm/page_owner: fix for deferred struct page init

From: Michal Hocko
Date: Mon Jan 07 2019 - 13:43:15 EST


On Fri 04-01-19 15:18:08, Qian Cai wrote:
[...]
> Though, I can't see any really benefit of this approach apart from "beautify"

This is not about beautifying! This is about making the code long term
maintainable. As you can see it is just too easy to break it with the
current scheme. And that is bad especially when the code is broken
because of an optimization.

--
Michal Hocko
SUSE Labs