Re: [PATCH 4/11] KVM/MMU: Introduce tlb flush with range list

From: Paolo Bonzini
Date: Mon Jan 07 2019 - 11:39:43 EST


On 04/01/19 09:53, lantianyu1986@xxxxxxxxx wrote:
> struct kvm_mmu_page {
> struct list_head link;
> +
> + /*
> + * Tlb flush with range list uses struct kvm_mmu_page as list entry
> + * and all list operations should be under protection of mmu_lock.
> + */
> + struct list_head flush_link;
> struct hlist_node hash_link;
> bool unsync;
>
> @@ -443,6 +449,7 @@ struct kvm_mmu {

Again, it would be nice not to grow the struct too much, though I
understand that it's already relatively big (168 bytes).

Can you at least make this an hlist, so that it only takes a single word?

Paolo