Re: [PATCH v7 21/22] ptrace: add PTRACE_GET_SYSCALL_INFO request

From: Dmitry V. Levin
Date: Mon Jan 07 2019 - 09:58:13 EST


Hi,

Looks like we need help to overcome this alpha specific issue:

On Mon, Jan 07, 2019 at 03:05:23PM +0800, kbuild test robot wrote:
> Hi Elvira,
>
> Thank you for the patch! Yet something to improve:
>
> [auto build test ERROR on linus/master]
> [also build test ERROR on v5.0-rc1]
> [cannot apply to next-20190103]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>
> url: https://github.com/0day-ci/linux/commits/Dmitry-V-Levin/asm-generic-syscall-h-prepare-for-inclusion-by-other-files/20190107-115241
> config: alpha-allmodconfig (attached as .config)
> compiler: alpha-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
> reproduce:
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # save the attached .config to linux build tree
> GCC_VERSION=7.2.0 make.cross ARCH=alpha
>
> All errors (new ones prefixed by >>):
>
> kernel/ptrace.c: In function 'ptrace_get_syscall_info':
> >> kernel/ptrace.c:944:20: error: implicit declaration of function 'user_stack_pointer'; did you mean 'xa_tag_pointer'? [-Werror=implicit-function-declaration]
> .stack_pointer = user_stack_pointer(regs),
> ^~~~~~~~~~~~~~~~~~
> xa_tag_pointer
> In file included from arch/alpha/include/asm/syscall.h:6:0,
> from include/linux/audit.h:214,
> from kernel/ptrace.c:24:

The mandatory function
static inline unsigned long user_stack_pointer(struct pt_regs *regs)
is not implemented on alpha, and I don't know how to implement it because
the relevant information is not available via struct pt_regs.
On alpha
task_thread_info(task)->pcb.usp
is used to obtain the user stack pointer.


--
ldv

Attachment: signature.asc
Description: PGP signature