Re: linux-5.0-rc1/drivers/staging/rtl8188eu/hal/hal8188e_rate_adaptive.c:412]: (style) Expression is always false

From: gregkh@xxxxxxxxxxxxxxxxxxx
Date: Mon Jan 07 2019 - 07:28:04 EST


On Mon, Jan 07, 2019 at 11:40:08AM +0000, David Binderman wrote:
>
> Hello there,
>
> linux-5.0-rc1/drivers/staging/rtl8188eu/hal/hal8188e_rate_adaptive.c:412]: (style) Expression is always false because 'else if' condition matches previous condition at line 410.
>
> Source code is
>
> else if (pRaInfo->HighestRate > 0x0b)
> pRaInfo->PTModeSS = 2;
> else if (pRaInfo->HighestRate > 0x0b)
> pRaInfo->PTModeSS = 1;
>
> Suggest code rework.

Patches are always gladly accepted!

thanks,

greg k-h