Re: [PATCH] fsi:fsi-sbefifo: Fix possible concurrency use-after-free bugs in sbefifo_user_release

From: David Howells
Date: Wed Jan 02 2019 - 04:34:58 EST


Jia-Ju Bai <baijiaju1990@xxxxxxxxx> wrote:

> + mutex_lock(&user->file_lock);
> sbefifo_release_command(user);
> free_page((unsigned long)user->cmd_page);
> + mutex_unlock(&user->file_lock);

It shouldn't be necessary to do the free_page() call inside the locked
section.

David