Re: [PATCH 3/3] firmware: rewrite Makefile

From: Masahiro Yamada
Date: Sat Dec 22 2018 - 11:59:52 EST


On Fri, Dec 21, 2018 at 5:43 PM Masahiro Yamada
<yamada.masahiro@xxxxxxxxxxxxx> wrote:
>
> Clean up the Makefile. Equivalent *.gen.S files are produced.
>
> - Use filechk to remove ugly wordsize_deps
>
> - Get FWNAME, FWSTR, ASM_WORD, ASM_ALIGN, and PROGBITS out of the
> recipe for readability
>
> - Move mkdir into the recipe
>
> - Clean up generated directories by 'make clean'
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
> ---
>

> -targets := $(patsubst $(obj)/%,%, \
> - $(shell find $(obj) -name \*.gen.S 2>/dev/null))
> +targets := $(shell cd $(obj) && find * -name '*.gen.S')
> +clean-dirs := $(shell cd $(obj) && find * -maxdepth 0 -type d)

This 'find' emits a warning for out-of-tree build.
So, I will get it back to the original code.


--
Best Regards
Masahiro Yamada