Re: [PATCH 4/6] psi: introduce state_mask to represent stalled psi states

From: Peter Zijlstra
Date: Tue Dec 18 2018 - 05:17:52 EST


On Mon, Dec 17, 2018 at 05:14:53PM -0800, Suren Baghdasaryan wrote:
> On Mon, Dec 17, 2018 at 7:55 AM Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
> > > + if (state_mask & (1 << s))
> >
> > We have the BIT() macro, but I'm honestly not sure that will improve
> > things.
>
> I was mimicking the rest of the code in psi.c that uses this kind of
> bit masking. Can change if you think that would be better.

Yeah, I really don't know.. keep it as is I suppose.