Re: [PATCH] serial: uartps: Add the device_init_wakeup

From: Michal Simek
Date: Mon Dec 17 2018 - 10:33:05 EST


On 17. 12. 18 16:15, Greg Kroah-Hartman wrote:
> On Wed, Dec 05, 2018 at 02:20:11PM +0100, Michal Simek wrote:
>> From: Shubhrajyoti Datta <shubhrajyoti.datta@xxxxxxxxxx>
>>
>> Initialise the device wakeup.
>
> Why? This says what happened, which you can see from the patch itself,
> but it does not say why this is needed at all.

We will fix this.

>
> Also, you sent 4 patches, without any numbering, so I have no idea what
> order to apply them in.
>
> Please fix the changelog entries up and send this as a patch series so
> that I can correctly apply them.

They are all independent that's why I have sent them separately as
single patches.

Thanks,
Michal