Re: [PATCH] Documentation: admin-guide: PM: Add cpuidle document

From: Rafael J. Wysocki
Date: Wed Nov 28 2018 - 04:11:31 EST


On Wed, Nov 28, 2018 at 6:48 AM Viresh Kumar <viresh.kumar@xxxxxxxxxx> wrote:
>
> On 26-11-18, 14:11, Rafael J. Wysocki wrote:
> > From: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
> >
> > Important information is missing from user/admin cpuidle documentation
> > available today, so add a new user/admin document for cpuidle containing
> > current and comprehensive information to admin-guide and drop the old
> > .txt documents it is replacing.
> >
> > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
> > ---
> > Documentation/admin-guide/pm/cpuidle.rst | 603 +++++++++++++++++++++++++
> > Documentation/admin-guide/pm/working-state.rst | 1
> > Documentation/cpuidle/core.txt | 23
> > Documentation/cpuidle/sysfs.txt | 98 ----
> > 4 files changed, 604 insertions(+), 121 deletions(-)
>
> Nice work Rafael. Minor nits below..

Thanks for the typo fixes. The spellchecker I have here evidently doesn't work.

[cut]

> Maybe I missed, but I couldn't find any text that says what state 0, 1, ... N
> mean.

There is a paragraph on that above.

> Like which is the deepest idle state and which one is the shallowest.

But this part is missing, good catch!

Thanks,
Rafael