Re: [PATCH v2 1/7] dt-bindings: msm/dsi: Add ref clock for PHYs

From: Doug Anderson
Date: Wed Nov 28 2018 - 00:41:59 EST


Hi,

On Mon, Nov 26, 2018 at 3:12 PM Matthias Kaehlcke <mka@xxxxxxxxxxxx> wrote:
>
> Allow the PHY drivers to get the ref clock from the DT.
>
> Signed-off-by: Matthias Kaehlcke <mka@xxxxxxxxxxxx>
> ---
> Changes in v2:
> - add the ref clock for all PHYs, not only the 10nm one
> - updated commit message
> ---
> Documentation/devicetree/bindings/display/msm/dsi.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/display/msm/dsi.txt b/Documentation/devicetree/bindings/display/msm/dsi.txt
> index dfc743219bd88..b0485559a719c 100644
> --- a/Documentation/devicetree/bindings/display/msm/dsi.txt
> +++ b/Documentation/devicetree/bindings/display/msm/dsi.txt
> @@ -106,6 +106,7 @@ Required properties:
> - clocks: Phandles to device clocks. See [1] for details on clock bindings.
> - clock-names: the following clocks are required:
> * "iface"
> + * "ref"

We can't quite make ref "required" because there are some old device
tree files dating back to 2016 that would be broken. It could be
listed as optional, but I _think_ Rob is OK with it being listed as
"required" for all new device tree files with the footnote that if
it's not present then the code will still work.