Re: [PATCH net-next 3/3] vhost: don't touch avail ring if in_order is negotiated

[Jason Wang]

On 2018/11/23 äå11:41, Michael S. Tsirkin wrote:
> On Fri, Nov 23, 2018 at 11:00:16AM +0800, Jason Wang wrote:
> > Device use descriptors table in order, so there's no need to read
> > index from available ring. This eliminate the cache contention on
> > avail ring completely.
> Well this isn't what the in order feature says in the spec.
>
> It forces the used ring to be in the same order as
> the available ring. So I don't think you can skip
> checking the available ring.


Maybe I miss something. The spec 
(https://github.com/oasis-tcs/virtio-spec master) said: "If 
VIRTIO_F_IN_ORDER has been negotiated, driver uses descriptors in ring 
order: starting from offset 0 in the table, and wrapping around at the 
end of the table."

Even if I was wrong, maybe it's time to force this consider the obvious 
improvement it brings? And maybe what you said is the reason that we 
only allow the following optimization only for packed ring?

"notify the use of a batch of buffers to the driver by only writing out 
a single used descriptor with the Buffer ID corresponding to the last 
descriptor in the batch. "

This seems another good optimization for packed ring as well.


> And in fact depending on
> ring size and workload, using all of descriptor buffer might
> cause a slowdown.


This is not the sin of in order but the size of the queue I believe?


> Rather you should be able to get
> about the same speedup, but from skipping checking
> the used ring in virtio.


Yes, I've made such changes in virtio-net pmd. But since we're testing 
it with vhost-kernel, the main contention was on available. So the 
improvement was not obvious.

Thanks


> > Virito-user + vhost_kernel + XDP_DROP gives about ~10% improvement on
> > TX from 4.8Mpps to 5.3Mpps on Intel(R) Core(TM) i7-5600U CPU @
> > 2.60GHz.
> >
> > Signed-off-by: Jason Wang <jasowang@xxxxxxxxxx>
> > ---
> >   drivers/vhost/vhost.c | 19 ++++++++++++-------
> >   1 file changed, 12 insertions(+), 7 deletions(-)
> >
> > diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
> > index 3a5f81a66d34..c8be151bc897 100644
> > --- a/drivers/vhost/vhost.c
> > +++ b/drivers/vhost/vhost.c
> > @@ -2002,6 +2002,7 @@ int vhost_get_vq_desc(struct vhost_virtqueue *vq,
> >   	__virtio16 avail_idx;
> >   	__virtio16 ring_head;
> >   	int ret, access;
> > +	bool in_order = vhost_has_feature(vq, VIRTIO_F_IN_ORDER);
> >   
> >   	/* Check it isn't doing very strange things with descriptor numbers. */
> >   	last_avail_idx = vq->last_avail_idx;
> > @@ -2034,15 +2035,19 @@ int vhost_get_vq_desc(struct vhost_virtqueue *vq,
> >   
> >   	/* Grab the next descriptor number they're advertising, and increment
> >   	 * the index we've seen. */
> > -	if (unlikely(vhost_get_avail(vq, ring_head,
> > -		     &vq->avail->ring[last_avail_idx & (vq->num - 1)]))) {
> > -		vq_err(vq, "Failed to read head: idx %d address %p\n",
> > -		       last_avail_idx,
> > -		       &vq->avail->ring[last_avail_idx % vq->num]);
> > -		return -EFAULT;
> > +	if (!in_order) {
> > +		if (unlikely(vhost_get_avail(vq, ring_head,
> > +		    &vq->avail->ring[last_avail_idx & (vq->num - 1)]))) {
> > +			vq_err(vq, "Failed to read head: idx %d address %p\n",
> > +				last_avail_idx,
> > +				&vq->avail->ring[last_avail_idx % vq->num]);
> > +			return -EFAULT;
> > +		}
> > +		head = vhost16_to_cpu(vq, ring_head);
> > +	} else {
> > +		head = last_avail_idx & (vq->num - 1);
> >   	}
> >   
> > -	head = vhost16_to_cpu(vq, ring_head);
> >   
> >   	/* If their number is silly, that's an error. */
> >   	if (unlikely(head >= vq->num)) {
> > --
> > 2.17.1