Re: [PATCH v2] rtc: max8997: Fix the returned value in case of error in 'max8997_rtc_read_alarm()'

From: Alexandre Belloni
Date: Thu Nov 22 2018 - 12:12:46 EST


On 14/11/2018 18:19:51+0100, Christophe JAILLET wrote:
> In case of error, we return 0.
> This is spurious and not consistent with the other functions of the driver.
> Propagate the error code instead.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
> ---
> v2: re-word changelog and remove Fixes tag.
> (not sure if any should be provided, and which one would be the best)
> ---
> drivers/rtc/rtc-max8997.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Applied, thanks.

--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com