Re: [PATCH] ipc/shm.c: removed 'int err' from shm_get_policy()

From: Andrew Morton
Date: Thu Nov 22 2018 - 00:07:35 EST


On Sun, 18 Nov 2018 23:49:11 +0000 danielijrobson@xxxxxxxxx wrote:

> removed unneeded variable in shm_get_policy()
>
> ...
>
> --- a/ipc/shm.c
> +++ b/ipc/shm.c
> @@ -461,11 +461,10 @@ static int shm_set_policy(struct vm_area_struct *vma, struct mempolicy *new)
> {
> struct file *file = vma->vm_file;
> struct shm_file_data *sfd = shm_file_data(file);
> - int err = 0;
>
> if (sfd->vm_ops->set_policy)
> - err = sfd->vm_ops->set_policy(vma, new);
> - return err;
> + return sfd->vm_ops->set_policy(vma, new);
> + return 0;
> }

Sorry, I don't think this is enough of an improvement to justify adding
the patch.