RE: [PATCH net-next 3/8] net: hns3: Add "FD flow table" info query function

From: Salil Mehta
Date: Wed Nov 21 2018 - 11:26:11 EST


Hi Jacub,

> From: Jakub Kicinski [mailto:jakub.kicinski@xxxxxxxxxxxxx]
> Sent: Monday, November 19, 2018 10:31 PM
> To: Salil Mehta <salil.mehta@xxxxxxxxxx>
> Cc: davem@xxxxxxxxxxxxx; Zhuangyuzeng (Yisen) <yisen.zhuang@xxxxxxxxxx>;
> lipeng (Y) <lipeng321@xxxxxxxxxx>; mehta.salil@xxxxxxxxxx;
> netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Linuxarm
> <linuxarm@xxxxxxxxxx>; Liuzhongzhu <liuzhongzhu@xxxxxxxxxx>
> Subject: Re: [PATCH net-next 3/8] net: hns3: Add "FD flow table" info
> query function
>
> On Mon, 19 Nov 2018 21:18:40 +0000, Salil Mehta wrote:
> > diff --git
> a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.h.rej
> b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.h.rej
> > new file mode 100644
> > index 000000000000..be7d0dea06e7
> > --- /dev/null
> > +++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.h.rej
> > @@ -0,0 +1,12 @@
> > +*************** int hclge_set_vlan_filter(struct hnae3_handle
> *handle, __be16 proto,
> > +*** 800,803 ****
> > + void hclge_reset_vf_queue(struct hclge_vport *vport, u16 queue_id);
> > + int hclge_cfg_flowctrl(struct hclge_dev *hdev);
> > + int hclge_func_reset_cmd(struct hclge_dev *hdev, int func_id);
> > + #endif
> > +--- 800,804 ----
> > + void hclge_reset_vf_queue(struct hclge_vport *vport, u16 queue_id);
> > + int hclge_cfg_flowctrl(struct hclge_dev *hdev);
> > + int hclge_func_reset_cmd(struct hclge_dev *hdev, int func_id);
> > ++ int hclge_dbg_run_cmd(struct hnae3_handle *handle, char *cmd_buf);
> > + #endif
>
> You probably don't need this.

Goodness! I was on a transit while I floated this patch-set, somehow
missed my quick review. Sorry for this and thanks for catching!

Best regards
Salil