Re: [PATCH 08/16] arm: dts: rda8810pl: Add interrupt controller support

From: Manivannan Sadhasivam
Date: Tue Nov 20 2018 - 14:28:57 EST


Hi Rob,

On Mon, Nov 19, 2018 at 12:29:07PM -0600, Rob Herring wrote:
> On Mon, Nov 19, 2018 at 11:11 AM Manivannan Sadhasivam
> <manivannan.sadhasivam@xxxxxxxxxx> wrote:
> >
> > Add interrupt controller support for RDA Micro RDA8810PL SoC.
>
> There's no point in splitting this to a separate patch. Without it,
> the DT is not functional.
>

Okay. Will merge this patch with SoC DT patch.

> > Signed-off-by: Andreas Färber <afaerber@xxxxxxx>
> > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>
> > ---
> > arch/arm/boot/dts/rda8810pl.dtsi | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/rda8810pl.dtsi b/arch/arm/boot/dts/rda8810pl.dtsi
> > index 7f1ff2021eff..093d6980bfbd 100644
> > --- a/arch/arm/boot/dts/rda8810pl.dtsi
> > +++ b/arch/arm/boot/dts/rda8810pl.dtsi
> > @@ -9,6 +9,7 @@
> >
> > / {
> > compatible = "rda,8810pl";
> > + interrupt-parent = <&intc>;
> > #address-cells = <1>;
> > #size-cells = <1>;
> >
> > @@ -49,6 +50,13 @@
> > #address-cells = <1>;
> > #size-cells = <1>;
> > ranges = <0x0 0x20800000 0x100000>;
> > +
> > + intc: interrupt-controller {
>
>
> unit-address?
>

Will add it.

Thanks,
Mani

> > + compatible = "rda,8810pl-intc";
> > + reg = <0x0 0x1000>;
> > + interrupt-controller;
> > + #interrupt-cells = <2>;
> > + };
> > };
> >
> > apb@20900000 {
> > --
> > 2.17.1
> >