Re: [PATCH 7/7] regulator: core: Remove loop disabling supplies in regulator_force_disable()

[Doug Anderson]

Hi,

On Mon, Nov 19, 2018 at 4:27 PM Douglas Anderson <dianders@xxxxxxxxxxxx> wrote:
>
> In regulator_force_disable() there was a strange loop that looked like:
>
>   while (rdev->open_count--)
>     regulator_disable(rdev->supply);
>
> I'm not totally sure what the goal was for this loop, but it seems
> wrong to me.  If anything I think maybe we should have been looping
> over our use_count, but even that might be a little strange.  For now
> let's just remove the code and we can add something back in if someone
> can explain what's expected.
>
> Fixes: f8702f9e4aa7 ("regulator: core: Use ww_mutex for regulators locking")
> Signed-off-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
> ---
>
>  drivers/regulator/core.c | 4 ----
>  1 file changed, 4 deletions(-)

For breadcrumbs: the next version of this patch is now squashed into
("[PATCH v2 2/2] regulator: core: Avoid propagating to supplies when
possible") AKA <http://lkml.kernel.org/r/20181120175255.227783-2-dianders@xxxxxxxxxxxx>

-Doug