Re: [PATCH] watchdog: cpwd: add of_node_put()

[Guenter Roeck]

On 11/20/18 5:23 AM, Yangtao Li wrote:
> use of_node_put() to release the refcount.
>
> Signed-off-by: Yangtao Li <tiny.windzz@xxxxxxxxx>
> ---
>   drivers/watchdog/cpwd.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/watchdog/cpwd.c b/drivers/watchdog/cpwd.c
> index aee0b25cf10d..d3a81642ada5 100644
> --- a/drivers/watchdog/cpwd.c
> +++ b/drivers/watchdog/cpwd.c
> @@ -617,6 +617,7 @@ static int cpwd_probe(struct platform_device *op)
>   
>   	platform_set_drvdata(op, p);
>   	cpwd_device = p;
> +	of_node_put(options);

It would be better to do that right after its last use to also cover
error handling.

Guenter

>   	return 0;
>   
>   out_unregister: