Re: [RFC PATCH] zinc chacha20 generic implementation using crypto API code

From: Jason A. Donenfeld
Date: Mon Nov 19 2018 - 22:08:36 EST


Hi Herbert,

On Tue, Nov 20, 2018 at 4:06 AM Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote:
> > I'd still prefer to see the conversion patches included. Skipping them would be
> > kicking the can down the road and avoiding issues that will need to be addressed
> > anyway. Like you, I don't want a "half-baked concoction that will be maybe
> > possibly be replaced 'later'" :-)
>
> Are you guys talking about the conversion patches to eliminate the
> two copies of chacha code that would otherwise exist in crypto as
> well as in zinc?
>
> If so I think that's not negotiable. Having two copies of the same
> code is just not acceptable.

Yes, that's the topic. Eric already expressed his preference to keep
them, and I agreed, so the plan is to keep them.

Jason