Re: [PATCH v2 4/5] mips: add system call table generation support

[Arnd Bergmann]

On Thu, Nov 15, 2018 at 7:15 AM Firoz Khan <firoz.khan@xxxxxxxxxx> wrote:
>
> The system call tables are in different format in all
> architecture and it will be difficult to manually add,
> modify or delete the syscall table entries in the res-
> pective files. To make it easy by keeping a script and
> which will generate the uapi header and syscall table
> file. This change will also help to unify the implemen-
> tation across all architectures.

This looks great to me, just one question:

> +# The <abi> is always "64" for this file.
> +#
> +0      64      read                            sys_read
> +1      64      write                           sys_write

What is the reason for using '64', 'n32', and 'o32' respectively in
the ABI field
but use 'common' in other architectures that have a table of entries that are
all for the same architecture?

       Arnd