Re: [PATCH] pinctrl: meson: fix pull enable register calculation

From: Linus Walleij
Date: Mon Nov 19 2018 - 08:18:35 EST


On Tue, Nov 13, 2018 at 11:55 AM Jerome Brunet <jbrunet@xxxxxxxxxxxx> wrote:

> We just changed the code so we apply bias disable on the correct
> register but forgot to align the register calculation. The result
> is that we apply the change on the correct register, but possibly
> at the incorrect offset/bit
>
> This went undetected because offsets tends to be the same between
> REG_PULL and REG_PULLEN for a given pin the EE controller. This
> is not true for the AO controller.
>
> Fixes: e39f9dd8206a ("pinctrl: meson: fix pinconf bias disable")
> Signed-off-by: Jerome Brunet <jbrunet@xxxxxxxxxxxx>

Patch applied for fixes.

Yours,
Linus Walleij