Re: [PATCH] mtd: rawnand: qcom: Namespace prefix some commands

From: Miquel Raynal
Date: Sat Nov 17 2018 - 16:39:55 EST


Hi Olof,

Olof Johansson <olof@xxxxxxxxx> wrote on Fri, 16 Nov 2018 19:43:27
-0800:

> PAGE_READ is used by RISC-V arch code included through mm headers,
> and it makes sense to bring in a prefix on these in the driver.
>
> drivers/mtd/nand/raw/qcom_nandc.c:153: warning: "PAGE_READ" redefined
> #define PAGE_READ 0x2
> In file included from include/linux/memremap.h:7,
> from include/linux/mm.h:27,
> from include/linux/scatterlist.h:8,
> from include/linux/dma-mapping.h:11,
> from drivers/mtd/nand/raw/qcom_nandc.c:17:
> arch/riscv/include/asm/pgtable.h:48: note: this is the location of the previous definition
>
> Caught by riscv allmodconfig.
>
> Signed-off-by: Olof Johansson <olof@xxxxxxxxx>
> ---

Reviewed-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx>

Boris, do you want to queue this as a fix?

Thanks,
MiquÃl