Re: [Patch v4 07/18] x86/smt: Convert cpu_smt_control check to cpu_smt_enabled static key

From: Tim Chen
Date: Wed Nov 07 2018 - 20:43:15 EST


On 11/03/2018 11:29 AM, Thomas Gleixner wrote:
> Tim,
>
> On Tue, 30 Oct 2018, Tim Chen wrote:
>
>> Change the SMT code paths check from using cpu_smt_control to
>> cpu_smt_enabled static key. This saves a branching check.
>
> and adds extra size to the kernel for the patching. The only reason why it
> would make sense for kvm is that then the EXPORT of cpu_smt_control can go
> away, which takes more space than the patch data.
>

Should I just drop this patch then and only replace
sched_smt_present with cpu_smt_enabled?

Tim