Re: [PATCH] scripts/spdxcheck: make python3 compliant

From: Andrew Morton
Date: Wed Nov 07 2018 - 18:32:57 EST


On Tue, 23 Oct 2018 09:08:02 +0200 Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> wrote:

> Without this change the following happens when using Python3 (3.6.6):
>
> $ echo "GPL-2.0" | python3 scripts/spdxcheck.py -
> FAIL: 'str' object has no attribute 'decode'
> Traceback (most recent call last):
> File "scripts/spdxcheck.py", line 253, in <module>
> parser.parse_lines(sys.stdin, args.maxlines, '-')
> File "scripts/spdxcheck.py", line 171, in parse_lines
> line = line.decode(locale.getpreferredencoding(False), errors='ignore')
> AttributeError: 'str' object has no attribute 'decode'
>
> So as the line is already a string, there is no need to decode it and
> the line can be dropped.

I suppose people might want to run spdxcheck.py against (say) 4.19.x
using python3. So I'll add a cc:stable here, OK?