Re: [PATCH v4 2/3] arm64: implement live patching

From: Miroslav Benes
Date: Tue Nov 06 2018 - 11:49:12 EST


Hi,

On Fri, 26 Oct 2018, Torsten Duwe wrote:

> Based on ftrace with regs, do the usual thing.
> (see Documentation/livepatch/livepatch.txt)
>
> Use task flag bit 6 to track patch transisiton state for the consistency
> model. Add it to the work mask so it gets cleared on all kernel exits to
> userland.
>
> Tell livepatch regs->pc is the place to change the return address.
> Make sure the graph tracer call hook is only called on the final function
> entry in case regs->pc gets modified after an interception.
>
> Signed-off-by: Torsten Duwe <duwe@xxxxxxx>

It looks good now apart from arm64 asm part which should be reviewed by
someone else.

However, could you summarize our analysis regarding post-module-load calls
of apply_relocate_add() in the commit log, please? It is important for
future reference.

Thanks,
Miroslav