Re: [driver-core PATCH v5 1/9] workqueue: Provide queue_work_node to queue work near a given NUMA node

From: Alexander Duyck
Date: Tue Nov 06 2018 - 11:27:21 EST


On Mon, 2018-11-05 at 16:42 -0800, Bart Van Assche wrote:
> On Mon, 2018-11-05 at 13:11 -0800, Alexander Duyck wrote:
> > +/**
> > + * workqueue_select_cpu_near - Select a CPU based on NUMA node
> > + * @node: NUMA node ID that we want to bind a CPU from
>
> ^^^^
> select?
> > + /* If CPU is valid return that, otherwise just defer */
> > + return (cpu < nr_cpu_ids) ? cpu : WORK_CPU_UNBOUND;
>
> Please leave out the superfluous parentheses if this patch series would have to
> be reposted.
>
> Anyway:
>
> Reviewed-by: Bart Van Assche <bvanassche@xxxxxxx>

I will incorporate you suggestions and add your Reviewed-by for the
next submission.

Thanks.

- Alex