Re: [PATCH v2 1/3] lib: cordic: Move cordic macros and defines to header file

From: Priit Laes
Date: Tue Nov 06 2018 - 02:15:04 EST


On Mon, Nov 05, 2018 at 11:02:35PM +0100, Arend van Spriel wrote:
> On 11/5/2018 8:37 PM, Priit Laes wrote:
> > Also append CORDIC_ prefix to nonprefixed macros.
>
> Bit annoying that you made me look at LKML for this patch. Can you just post
> the entire series to linux-wireless so Kalle can take it all through his
> tree. Also the commit message is a bit thin. Please explain why these are
> moved to the header file.

Sorry, I messed up again while trying to automate the send-email with
get_maintainers script (dry-run argument did not work .gitconfig :S)

>
> Reviewed-by: Arend van Spriel <arend.vanspriel@xxxxxxxxxxxx>
> > Signed-off-by: Priit Laes <plaes@xxxxxxxxx>
> > ---
> > include/linux/cordic.h | 9 +++++++++
> > lib/cordic.c | 23 +++++++----------------
> > 2 files changed, 16 insertions(+), 16 deletions(-)
>