Re: [tip:x86/urgent] x86/vsmp: Remove dependency on pv_irq_ops

[Eial Czerwacki]

Greetings,

On 11/05/2018 05:44 PM, Thomas Gleixner wrote:
> On Mon, 5 Nov 2018, Ingo Molnar wrote:
> 
>>
>> * tip-bot for Eial Czerwacki <tipbot@xxxxxxxxx> wrote:
>>
>>> Commit-ID:  7f2d7f8190d856949d8aaab55d3902cd10ea1048
>>> Gitweb:     https://git.kernel.org/tip/7f2d7f8190d856949d8aaab55d3902cd10ea1048
>>> Author:     Eial Czerwacki <eial@xxxxxxxxxxx>
>>> AuthorDate: Mon, 5 Nov 2018 10:01:04 +0200
>>> Committer:  Thomas Gleixner <tglx@xxxxxxxxxxxxx>
>>> CommitDate: Mon, 5 Nov 2018 12:33:47 +0100
>>>
>>> x86/vsmp: Remove dependency on pv_irq_ops
>>>
>>> vsmp dependency on pv_irq_ops has been removed some years ago, but the code
>>> still deals with pv_irq_ops.
>>
>> s/vsmp
>>  /vSMP
>>
>>> +#if defined CONFIG_PCI
>>
>> I don't think code was ever tested with PCI disabled?
>>
>> The above typoed sequence of code accidentally evaluates to 'true' 
>> regardless of CONFIG_PCI.
> 
> Grr. Indeed, missed that
> 
> 

actually I've tested it with CONFIG_PCI unset but evidently I've managed
to mess up the test somehow.
thanks for pointing this out, I'll send a patch that fixes it.

Eial.