Re: [tip:x86/urgent] x86/vsmp: Remove dependency on pv_irq_ops

From: Ingo Molnar
Date: Mon Nov 05 2018 - 10:41:48 EST



* tip-bot for Eial Czerwacki <tipbot@xxxxxxxxx> wrote:

> Commit-ID: 7f2d7f8190d856949d8aaab55d3902cd10ea1048
> Gitweb: https://git.kernel.org/tip/7f2d7f8190d856949d8aaab55d3902cd10ea1048
> Author: Eial Czerwacki <eial@xxxxxxxxxxx>
> AuthorDate: Mon, 5 Nov 2018 10:01:04 +0200
> Committer: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> CommitDate: Mon, 5 Nov 2018 12:33:47 +0100
>
> x86/vsmp: Remove dependency on pv_irq_ops
>
> vsmp dependency on pv_irq_ops has been removed some years ago, but the code
> still deals with pv_irq_ops.

s/vsmp
/vSMP

> +#if defined CONFIG_PCI

I don't think code was ever tested with PCI disabled?

The above typoed sequence of code accidentally evaluates to 'true'
regardless of CONFIG_PCI.

Thanks,

Ingo