Re: [PATCH v2 7/7] lightnvm: pblk: remove dead code in pblk_recov_l2p

[Sebastien Boisvert]

On 2018-11-05 7:26 a.m., Hans Holmberg wrote:
> From: Hans Holmberg <hans.holmberg@xxxxxxxxxxxx>
> 
> Remove the call to pblk_line_replace_data as it returns
> directly as we have not set l_mg->data_next yet.

You have the word "as" twice. Replace the second with "because".

> 
> Signed-off-by: Hans Holmberg <hans.holmberg@xxxxxxxxxxxx>
> ---
>  drivers/lightnvm/pblk-recovery.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/lightnvm/pblk-recovery.c b/drivers/lightnvm/pblk-recovery.c
> index 0fbd30e0a587..416d9840544b 100644
> --- a/drivers/lightnvm/pblk-recovery.c
> +++ b/drivers/lightnvm/pblk-recovery.c
> @@ -805,7 +805,6 @@ struct pblk_line *pblk_recov_l2p(struct pblk *pblk)
>  		WARN_ON_ONCE(!test_and_clear_bit(meta_line,
>  							&l_mg->meta_bitmap));
>  		spin_unlock(&l_mg->free_lock);
> -		pblk_line_replace_data(pblk);
>  	} else {
>  		spin_lock(&l_mg->free_lock);
>  		/* Allocate next line for preparation */
>