Re: [PATCH v4 11/12] iommu/vt-d: Shared virtual address in scalable mode

From: Christoph Hellwig
Date: Mon Nov 05 2018 - 02:15:30 EST


> --- a/include/linux/dma_remapping.h
> +++ b/include/linux/dma_remapping.h

FYI, this file seems to be entirely VT-D specific, but has an awfully
generic name. It should be renamed to something more suitable (or maybe
just merged into intel-iommu.h?) and also grow some comments describing
the contents.