Re: [PATCH anybus v2 1/5] misc: support the Arcx anybus bridge.

From: Linus Walleij
Date: Thu Nov 01 2018 - 17:54:03 EST


On Thu, Nov 1, 2018 at 6:17 PM Sven Van Asbroeck <thesven73@xxxxxxxxx> wrote:

> >> +static DEVICE_ATTR_RO(version);
> >
> > Do you need this in userspace really?
> >
> >> +static DEVICE_ATTR_RO(design_number);
> >
> > And this?
>
> Unfortunately, I do :(
> The application software reads these out and displays them in an UI. It's
> important to be able to see these on a running device.

OK...

> Perhaps there is another kernel abstraction I could use?

I don't think so. If you want to be pedantic, document the sysfs
files in Documentation/ABI/testing/sysfs-*

Maybe the properties should be on the bus though? I don't know :/

Yours,
Linus Walleij