Re: [PATCH AUTOSEL 3.18 22/22] mfd: menelaus: Fix possible race condition and leak

From: Sasha Levin
Date: Wed Oct 31 2018 - 21:29:40 EST


On Thu, Nov 01, 2018 at 01:27:08AM +0100, Alexandre Belloni wrote:
Hello,

On 31/10/2018 19:12:06-0400, Sasha Levin wrote:
- m->rtc = rtc_device_register(DRIVER_NAME,
- &m->client->dev,
- &menelaus_rtc_ops, THIS_MODULE);
- if (IS_ERR(m->rtc)) {
+ err = rtc_register_device(m->rtc);

This appeared in v4.13, this will not compile on v3.18.

Indeed, I guess I need more cross-compilers here. Thanks!

--
Thanks,
Sasha