Re: [PATCH v2 11/11] ext4: access to uninitialized bh fields in ext4_xattr_set_handle()

From: Andreas Dilger
Date: Wed Oct 31 2018 - 20:42:29 EST


On Oct 30, 2018, at 9:39 PM, Vasily Averin <vvs@xxxxxxxxxxxxx> wrote:
>
> On 10/31/2018 04:30 AM, Andreas Dilger wrote:
>> Could you please explain your statement below that on-stack
>> initialization does not zero unspecified fields? According
>> to documents I found, for example:
>>
>> https://gcc.gnu.org/onlinedocs/gcc/Designated-Inits.html
>>
>> they *are* initialized to zero.
>
> I did not know it,
> I re-checked it in generated assembler code and found that you
> are right and I was wrong.
>
> Please drop this patch,
> should I resend of rest of this patch set once again?

I don't think it is necessary to resend the whole patch series.
Ted should notice these emails on this patch and not apply it.

Cheers, Andreas





Attachment: signature.asc
Description: Message signed with OpenPGP