Re: [PATCH] pinctrl: meson: fix pinconf bias disable

From: Linus Walleij
Date: Wed Oct 31 2018 - 05:45:59 EST


On Tue, Oct 23, 2018 at 6:03 PM Jerome Brunet <jbrunet@xxxxxxxxxxxx> wrote:

> If a bias is enabled on a pin of an Amlogic SoC, calling .pin_config_set()
> with PIN_CONFIG_BIAS_DISABLE will not disable the bias. Instead it will
> force a pull-down bias on the pin.
>
> Instead of the pull type register bank, the driver should access the pull
> enable register bank.
>
> Fixes: 6ac730951104 ("pinctrl: add driver for Amlogic Meson SoCs")
> Signed-off-by: Jerome Brunet <jbrunet@xxxxxxxxxxxx>

Patch applied for fixes with Neil's ACK.

Yours,
Linus Walleij