Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

From: Mogens Jensen
Date: Tue Oct 30 2018 - 14:56:11 EST


âââââââ Original Message âââââââ
On Tuesday, October 30, 2018 4:04 PM, Hans de Goede <hdegoede@xxxxxxxxxx> wrote:

> Hi,
>
> On 30-10-18 16:46, Hans de Goede wrote:
>
> > Hi,
> > On 30-10-18 16:04, Pierre-Louis Bossart wrote:
> >
> > > In addition I am not aware of any baytrail device using plt_clk_0, so moving a common machine driver such a cht_bsw_max98090_ti to use plt_clk0 only would break other devices (e.g. Rambi/Orco). Asking for both clocks to be on might work though,
> >
> > Ok, so we need to have a DMI based quirk for the Swanky and maybe also
> > the clapper to use plt_clk_0 there. Asking for 2 clks if we only need
> > one does not seem like a good plan.
>
> Dean, Mogens,
>
> To write a proper patch for this I'm going to need DMI strings
> from your devices.
>
> Can you please run (as normal user):
>
> grep . /sys/class/dmi/id/* 2> /dev/null
>
> And reply with the output of this command?
I have attached the output from a coreboot seabios based clapper.

Should I still test 0001-ASoC-intel-cht_bsw_max98090_ti-Use-pmc_plt_clk_0-ins.patch with SND_SOC_INTEL_CHT_BSW_MAX98090_TI_MACH and asoundrc from Dean? There seems to have been some development in the case since that request was made.

/sys/class/dmi/id/bios_date:08/22/2014
/sys/class/dmi/id/bios_vendor:coreboot
/sys/class/dmi/id/chassis_type:3
/sys/class/dmi/id/chassis_vendor:GOOGLE
/sys/class/dmi/id/modalias:dmi:bvncoreboot:bvr:bd08/22/2014:svnGOOGLE:pnClapper:pvr1.0:cvnGOOGLE:ct3:cvr:
/sys/class/dmi/id/product_name:Clapper
/sys/class/dmi/id/product_version:1.0
/sys/class/dmi/id/sys_vendor:GOOGLE
/sys/class/dmi/id/uevent:MODALIAS=dmi:bvncoreboot:bvr:bd08/22/2014:svnGOOGLE:pnClapper:pvr1.0:cvnGOOGLE:ct3:cvr: