Re: [PATCH] regulator: bd718x7: add missing linux/of.h inclusion

From: Matti Vaittinen
Date: Mon Oct 29 2018 - 05:40:48 EST


Hello Mark,

I see we got build warning from 0-Day tests. It seems to me the
bd718x7.c file lacks of <linux/of.h> inclusion.

I am not sure what has happened as this include was added to bd71837.c
file with commit

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git/commit/?h=for-next&id=df43519eb706edfe951284a825642ce2e1d38d09

The bd71837.c was later renamed to bd718x7.c with
commit

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git/commit/drivers/regulator?h=for-next&id=2ece646c90c5b45dd76c76ea207a3f3459f2c472

So I am not sure where this include got lost. (I did search for all log
entries with my name and was not able to spot this change)
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git/log/drivers/regulator?h=for-next&qt=grep&q=Vaittinen

Should I just create another patch to you where this inclusion is done again
or is there some better way to handle this? Can you cherry pick or
re-apply the commit

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git/commit/?h=for-next&id=df43519eb706edfe951284a825642ce2e1d38d09

- even though the file was later renamed?

Br,
Matti Vaittinen

--
Matti Vaittinen
ROHM Semiconductors

~~~ "I don't think so," said Rene Descartes. Just then, he vanished ~~~