Re: [PATCH v3 2/5] nfc: pn532_uart: Add NXP PN532 to devicetree docs

From: Rob Herring
Date: Thu Oct 25 2018 - 17:54:51 EST


On Thu, Oct 25, 2018 at 03:29:33PM +0200, Lars Poeschel wrote:
> Add a simple binding doc for the pn532.
>
> Signed-off-by: Lars Poeschel <poeschel@xxxxxxxxxxx>
> ---
> Changes in v3:
> - seperate binding doc instead of entry in trivial-devices.txt
>
> .../devicetree/bindings/nfc/pn532.txt | 31 +++++++++++++++++++
> 1 file changed, 31 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/nfc/pn532.txt
>
> diff --git a/Documentation/devicetree/bindings/nfc/pn532.txt b/Documentation/devicetree/bindings/nfc/pn532.txt
> new file mode 100644
> index 000000000000..a2df72a5f504
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/nfc/pn532.txt
> @@ -0,0 +1,31 @@
> +NXP PN532 NFC Chip

What about the PN533?

> +
> +Required properties:
> +- compatible: Should be
> + - "nxp,pn532" Place a node with this inside the devicetree node of the bus
> + where the NFC chip is connected to.
> + Currently the kernel has phy bindings for uart and i2c.
> + - "nxp,pn532-i2c" (DEPRECATED) only works for the i2c binding.
> + - "nxp,pn533-i2c" (DEPRECATED) only works for the i2c binding.
> +
> +There are no additional properties provided by the driver at the moment.

I2C requires reg.

> +
> +Example uart:
> +
> +uart4: serial@49042000 {
> + compatible = "ti,omap3-uart";
> +
> + pn532: nfc {
> + compatible = "nxp,pn532";
> + };
> +};
> +
> +Example i2c:
> +
> +i2c1: i2c@0 {
> + compatible = "ti,omap3-i2c";
> +
> + pn532: nfc {
> + compatible = "nxp,pn532";
> + };
> +};
> --
> 2.19.1
>