Re: [PATCH net-next 0/4] net: ethernet: ti: cpsw: fix vlan mcast

From: Grygorii Strashko
Date: Thu Oct 25 2018 - 15:25:44 EST


Hi David,

On 10/25/18 1:34 PM, David Miller wrote:
From: Ivan Khoronzhuk <ivan.khoronzhuk@xxxxxxxxxx>
Date: Thu, 25 Oct 2018 01:10:55 +0300

The cpsw holds separate mcast entires for vlan entries. At this moment
driver adds only not vlan mcast addresses, omitting vlan/mcast entries.
As result mcast for vlans doesn't work. It can be fixed by adding same
mcast entries for every created vlan, but this patchseries uses more
sophisticated way and allows to create mcast entries only for vlans
that really require it. Generic functions from this series can be
reused for fixing vlan and macvlan unicast.

This is a bug fix but targetted at net-next, and indeed it is quite
invasive as it adds new core infrastructure and converts the generic
vlan code over to using it.

Unfortunately net-next is closed.

So if you want this bug fixed in mainline you will have to come up
with a less invasive fix, and resubmit this net-next approach when the
net-next tree opens back up.

I think it's ok to wait as this issue was always here, so it's not critical.

--
regards,
-grygorii