Re: [PATCH] drm: fix call_kern.cocci warnings (fwd)

[zhoucm1]

will send a fix soon.


Thanks,

David


On 2018å10æ25æ 15:57, Koenig, Christian wrote:
> Am 25.10.18 um 09:51 schrieb Maarten Lankhorst:
> > Op 25-10-18 om 08:53 schreef Christian KÃnig:
> > > Am 25.10.18 um 03:28 schrieb Zhou, David(ChunMing):
> > > > Reviewed-by: Chunming Zhou <david1.zhou@xxxxxxx>
> > > NAK, GFP_ATOMIC should be avoided.
> > >
> > > The correct solution is to move the allocation out of the spinlock or drop the lock and reacquire.
> > Yeah +1. Especially in a case like this where it's obvious to prevent. :)
> Another possibility would to not allocate the dummy fence at all.
>
> E.g. we just need a global instance of that which is always signaled and
> has a reference count of +1.
>
> Christian.