RE: [PATCH] tpm: tpm_try_transmit() refactor error flow.

From: Winkler, Tomas
Date: Wed Oct 24 2018 - 05:01:31 EST


>
> On Tue, 23 Oct 2018, Winkler, Tomas wrote:
> > To the out label we jump after we are done with locality and cmd
> > read() before we jump to locality 'locality'. We will need to add
> > another variable to check If cmd_ready() was called or not in order to
> > get rid of the extran label, it's not internally tracked so far.
>
> I think this is fine.
>
> Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@xxxxxxxxxxxxxxx>
> Tested-by: Jarkko Sakkinen <jarkko.sakkinen@xxxxxxxxxxxxxxx>
>
> I tested this by assigning rc error code instead of requesting locality in
> addition of testig unchanged code.
>
Great
Thanks
Tomas