Re: [PATCH v3 06/24] powerpc/mm: properly set PAGE_KERNEL flags in ioremap()

[LEROY Christophe]

Michael Ellerman <mpe@xxxxxxxxxxxxxx> a ÃcritÂ:

> Michael Ellerman <mpe@xxxxxxxxxxxxxx> writes:
>
> > Christophe Leroy <christophe.leroy@xxxxxx> writes:
> >
> > > Set PAGE_KERNEL directly in the caller and do not rely on a
> > > hack adding PAGE_KERNEL flags when _PAGE_PRESENT is not set.
> > >
> > > As already done for PPC64, use pgprot_cache() helpers instead of
> > > _PAGE_XXX flags in PPC32 ioremap() derived functions.
> > >
> > > Signed-off-by: Christophe Leroy <christophe.leroy@xxxxxx>
> >
> > Something in here is breaking my p5020ds (both 32-bit and 64-bit):
>
> Oh duh.
>
> That's because I didn't take patch 4.
>
> It didn't have any acks, but I guess I'll just merge it rather than
> breaking things.

Yes indeed. Maybe should I have followed it more carrefully to ensure  
it gets an ack.

Thanks
Christophe