Re: [PATCH v2 1/3] lib/vsprintf: Prepare for more general use of ptr_to_id()

From: Geert Uytterhoeven
Date: Fri Oct 12 2018 - 07:25:55 EST


Hi Petr,

On Fri, Oct 12, 2018 at 12:39 PM Petr Mladek <pmladek@xxxxxxxx> wrote:
> On Thu 2018-10-11 10:42:47, Geert Uytterhoeven wrote:
> > - Make the ptr argument const, to avoid adding casts in future
> > callers,
> > - Move the function and its dependencies up, so it can be called from
> > special pointer type formatting routines.
> >
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
>
> I have pushed the changes into printk.git,
> branch for-4.20-vsprintf-hash-fixes.
>
> Note that I have split it into two separate commits. The first one
> adds the const modifier. The second commit does a pure move of
> the code without any "hidden" changes. I forgot to ask for this
> when reviewing v1.
>
> You might see the result at
> https://git.kernel.org/pub/scm/linux/kernel/git/pmladek/printk.git/log/?h=for-4.20-vsprintf-hash-fixes

Thanks, looks good!

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds