Re: Question on FIELD_PREP() for static array

From: John Garry
Date: Thu Oct 11 2018 - 13:26:32 EST


Yeah, I have a patch now to reference it, but I don't see anything from
-Wvla with gcc 8.1?

I'm using a 7.3.1-based toolchain


See
https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git/commit/?id=3d7af878357acd9e37fc156928106f1a969c8942

and its parent.

Do you see -Wvla warnings there? Any idea how I could reproduce them?

I'll try it, thanks

3d7af878357acd9e37f builds ok. However I am using 20181010-next (I'm not sure what yours is based on), and I just noticed that it includes this new guy:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/Makefile?h=next-20181011&id=bc5701d8e27fd8beaf895176982fc6a97878f3b8

When I cherry-pick this onto your codebase@3d7af878357acd9e37f, the 82011 code has warns.

Thanks,
John



John


johannes

.