Re: [PATCH 10/11] spi: pxa2xx: Add ready signal

From: Lubomir Rintel
Date: Thu Oct 11 2018 - 12:13:37 EST


On Thu, 2018-10-11 at 09:28 +0200, Geert Uytterhoeven wrote:
> Hi Lubomir,
>
> On Wed, Oct 10, 2018 at 7:10 PM Lubomir Rintel <lkundrak@xxxxx>
> wrote:
> > Strobe a GPIO line when the slave TX FIFO is filled. This is how
> > the
> > Embedded Controller on an OLPC XO-1.75 machine, that happens to be
> > a SPI
> > master, learns that it can initiate a transaction.
> >
> > Signed-off-by: Lubomir Rintel <lkundrak@xxxxx>
>
> Thanks for your patch!
>
> I'm repeating my comments on the RFC below:

Ah, sorry for not addressing those; it somehow slipped through my
fingers. I'll wait a while to collect more feedback before sending v2
and then I'll include fixes for those.

Thanks for the review.

Lubo